[U-Boot] [PATCH 2/2] mtd: Get rid of board_mtdparts_default()

Enric Balletbo Serra eballetbo at gmail.com
Fri Dec 21 10:26:37 UTC 2018


Hi Boris,

Missatge de Boris Brezillon <boris.brezillon at bootlin.com> del dia dc.,
12 de des. 2018 a les 18:36:
>
> On Wed, 12 Dec 2018 12:37:04 +0100
> Ladislav Michl <ladis at linux-mips.org> wrote:
>
> > Now problem is that IGEPv2 comes with quite many configurations, some of
> > them are even customized, so static configuration is a show stopper
> > mainly as I do not know what devices are in field.
> > Another issue is how ubispl code works: It expects struct ubispl_info
> > filled with (among others) peb_offset of ubi partition. ubispl code counts
> > in terms of eraseblocks regardless of their size. So we would need to touch
> > this number when using static mtdparts.
>
> Okay.
>
> >
> > > > Hence runtime detection. That code could be used
> > > > on all OMAP3 boards as BootROM reads up to first four sectors searching
> > > > for SPL (MLO).
> > >
> > > Note that, for the nand side of things, you can also automate that using
> > > a u-boot script:
> > >
> > > nand info; setexpr splsize ${nand_erasesize} * 4; setenv mtdparts mtdparts=omap2-nand:0x${splsize}(SPL),-(UBI)
> >
> > That seems as a way to go!
>
> Glad you like this idea.
>
> >
> > > Shouldn't be hard to patch the onenand cmd to also expose writesize,
> > > erasesize and oobsize.
> >
> > Side note: I never fully understand why is OneNAND using separate set of
> > commands.
>
> Hehe. That's exactly what Miquel tries to address with the mtd command
> (one command to rule them all).
>
> >
> > Could you hold merging your paches until I implement above idea and test
> > it on a few boards? I know u-boot is now using two months merge window,
> > which is unfortunate, so I'll try to do it as soon as possible, but I do
> > not think I'll finish it till end of week.
>
> No worries. This is not urgent and can definitely wait 2019.04.
>

Yes, will be good if we can have the Ladis work merged at the same
time. He will probably have more variety of boards than me to test
this, but from my side, and after do some tests the patch LGTM

Acked-by: Enric Balletbo i Serra <enric.balletbo at collabora.com>

Thanks,
 Enric

> Thanks,
>
> Boris


More information about the U-Boot mailing list