[U-Boot] [PATCH v2 1/1] arm64: dts: marvell: mcbin: reserve PSCI area
Heinrich Schuchardt
xypron.glpk at gmx.de
Fri Dec 21 16:03:19 UTC 2018
On 12/21/18 4:37 PM, Stefan Roese wrote:
> Hi Heinrich,
>
> On 21.12.18 12:59, Heinrich Schuchardt wrote:
>> The memory area [0x4000000-0x4200000[ is occupied by the PSCI
>> firmware. Any
>
> Nitpicking: The closing bracket is wrong above. *If* you need to re-send,
> then please fix. Otherwise no need.
>
>> attempt to access it from U-Boot leads to an immediate crash.
>>
>> So let's make the same memory reservation as the vendor device tree.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> ---
>> cf. https://lkml.org/lkml/2018/12/21/253
>>
>> v2
>> add missing right brace
>> ---
>> arch/arm/dts/armada-8040-mcbin.dts | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/dts/armada-8040-mcbin.dts
>> b/arch/arm/dts/armada-8040-mcbin.dts
>> index f912596c2c..a039f5a790 100644
>> --- a/arch/arm/dts/armada-8040-mcbin.dts
>> +++ b/arch/arm/dts/armada-8040-mcbin.dts
>> @@ -28,6 +28,17 @@
>> reg = <0x0 0x0 0x0 0x80000000>;
>> };
>> + reserved-memory {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> +
>> + psci_reserved: psci-area at 4000000 {
>> + reg = <0x0 0x4000000 0x0 0x200000>;
>> + no-map;
>> + };
>> + };
>> +
>
> I'm wondering if this reservation is only necessary and at this address
> for the mcbin or also for other (or even all) Armada 7k/8k boards? If
> global, then it would be better to move this reservation to a common
> dtsi file instead.
>
> Thanks,
> Stefan
>
Hello Stefan,
I only have access to the MACCHIATObin.
But Marvell has the definition in
arch/arm64/boot/dts/marvell/armada-ap806.dtsi
Do I will resend the patch accordingly.
Best regards
Heinrich
More information about the U-Boot
mailing list