[U-Boot] [PATCH 1/1] distro_bootcmd: add NVME support

Simon Glass sjg at chromium.org
Fri Dec 21 21:15:57 UTC 2018


On Thu, 20 Dec 2018 at 18:18, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> Some boards support NVME drives. We should be able to use them as boot
> devices.
>
> NVME access requires running 'nvme scan'.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  include/config_distro_bootcmd.h | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>

Reviewed-by: Simon Glass <sjg at chromium.org>

BUT

with CONFIG_BLK we can enumerate all block devices without all of this
mess and we should be able to probe them too.

All nvme_scan_namespace() does is probe all the devices. We could do
the same thing generically.

So, I suggest we simplify this distro stuff to scan CONFIG_BLK and we
can drop most of the code and complexity.

Regards,
Simon


More information about the U-Boot mailing list