[U-Boot] Nokia N900: Broken comment after commit 278b90ce (configs: Migrate CONFIG_SYS_TEXT_BASE)

Tom Rini trini at konsulko.com
Thu Dec 27 18:56:57 UTC 2018


On Thu, Dec 27, 2018 at 07:45:15PM +0100, Pali Rohár wrote:

> Hi! Now I spotted that CONFIG_SYS_TEXT_BASE was moved/removed in commit
> 278b90ce786f73faf29aa522d5d101e1da006378 from include/configs/nokia_rx51.h
> file, but comment which described value for that macro is still on old
> place. See diff:
> 
> http://git.denx.de/?p=u-boot.git;a=blobdiff;f=include/configs/nokia_rx51.h;h=c9901e52510110ea34bd1ac6bcdc2a90a9bada8d;hp=6312ed737c7104b331c11c8e88808fcc10654718;hb=278b90ce786f73faf29aa522d5d101e1da006378;hpb=7c8f00e484658c673d32d8422c96cb64bb571063
> 
> Tom, can you move also comment to place where is now
> CONFIG_SYS_TEXT_BASE value for Nokia N900?

I'm a little confused.  We migrated the value set there to
configs/nokia_rx51_defconfig where it's still 0x80008000 should it have
been 0x80400000 ?  But that's not what the code was doing..

> Anyway, now I tested in qemu n900 emulator U-Boot version from master
> git branch and it is still working and able to boot 2.6.28 Maemo kernel!

Can you update .travis.yml to include running the n900 qemu setup?
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181227/b5c5ea7d/attachment.sig>


More information about the U-Boot mailing list