[U-Boot] Nokia N900: MTDPARTS_DEFAULT was removed in 43ede0bc (Kconfig: Migrate MTDIDS_DEFAULT / MTDPARTS_DEFAULT)

[Tom Rini]

On Thu, Dec 27, 2018 at 08:09:56PM +0100, Pali Rohár wrote:
> On Thursday 27 December 2018 13:57:59 Tom Rini wrote:
> > On Thu, Dec 27, 2018 at 07:52:54PM +0100, Pali Rohár wrote:
> > 
> > > Hello, it seems that MTD partition definitions for Nokia N900 were
> > > removed in commit 43ede0bca7fc1590b623832b743213b818257a27 (Kconfig:
> > > Migrate MTDIDS_DEFAULT / MTDPARTS_DEFAULT).
> > > 
> > > See diff:
> > > http://git.denx.de/?p=u-boot.git;a=blobdiff;f=include/configs/nokia_rx51.h;h=b7fe7341e407fd16275ed06d2cd399a3a2fc0e6a;hp=20b8c345f06620210d4852f547b1e64c54e48904;hb=43ede0bca7fc1590b623832b743213b818257a27;hpb=804dcf771aacc75f595d3656be0ca6a7887b6672
> > > 
> > > Can you bring them back?
> > > 
> > > Note that those PART*_* macros are used not only for constructing
> > > MTDPARTS_DEFAULT, but also for OMAP Nokia N900 atags, which are needed
> > > for booting Maemo 5.
> > 
> > Yes, please update the defconfig file with whatever needs to be in the
> > option there, thanks!
> 
> Looking at it... and it is problematic.
> 
> At time when Nokia N900 code was put into U-Boot mainline repository,
> UBIFS and OneNand code in U-Boot was broken. Therefore I added only
> #ifdef switch to enable MTD support optionally. Ideally once, OneNand is
> in U-Boot fixed, then it can be enabled. I do not know what is current
> state.

OneNAND is probably still broken then, and should probably just be
removed if so?

> And definition for MTD was not moved out of nokia_rx51.h file to
> nokia_rx51_defconfig. But if you look at old definition of
> MTDPART_DEFAULT it is composed from other macros in that nokia_rx51.h
> file.
> 
> So I cannot move it for obvious reason to nokia_rx51_defconfig, without
> including nokia_rx51.h in nokia_rx51_defconfig file. So how to solve
> this problem?

You should construct and pass the final string as it doesn't look like
it changes dynamically, right?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181227/cc7675af/attachment.sig>