[U-Boot] Nokia N900: Broken comment after commit 278b90ce (configs: Migrate CONFIG_SYS_TEXT_BASE)

[Tom Rini]

On Thu, Dec 27, 2018 at 08:49:22PM +0100, Pali Rohár wrote:
> On Thursday 27 December 2018 14:27:45 Tom Rini wrote:
> > On Thu, Dec 27, 2018 at 08:21:58PM +0100, Pali Rohár wrote:
> > > On Thursday 27 December 2018 14:10:26 Tom Rini wrote:
> > > > On Thu, Dec 27, 2018 at 08:05:38PM +0100, Pali Rohár wrote:
> > > > > On Thursday 27 December 2018 13:56:57 Tom Rini wrote:
> > > > > > On Thu, Dec 27, 2018 at 07:45:15PM +0100, Pali Rohár wrote:
> > > > > > 
> > > > > > > Hi! Now I spotted that CONFIG_SYS_TEXT_BASE was moved/removed in commit
> > > > > > > 278b90ce786f73faf29aa522d5d101e1da006378 from include/configs/nokia_rx51.h
> > > > > > > file, but comment which described value for that macro is still on old
> > > > > > > place. See diff:
> > > > > > > 
> > > > > > > http://git.denx.de/?p=u-boot.git;a=blobdiff;f=include/configs/nokia_rx51.h;h=c9901e52510110ea34bd1ac6bcdc2a90a9bada8d;hp=6312ed737c7104b331c11c8e88808fcc10654718;hb=278b90ce786f73faf29aa522d5d101e1da006378;hpb=7c8f00e484658c673d32d8422c96cb64bb571063
> > > > > > > 
> > > > > > > Tom, can you move also comment to place where is now
> > > > > > > CONFIG_SYS_TEXT_BASE value for Nokia N900?
> > > > > > 
> > > > > > I'm a little confused.  We migrated the value set there to
> > > > > > configs/nokia_rx51_defconfig where it's still 0x80008000 should it have
> > > > > > been 0x80400000 ?  But that's not what the code was doing..
> > > > > 
> > > > > I do not know current state of U-Boot loading, but in past there was a
> > > > > problem with Nokia N900. On N900, U-Boot image is loaded by Nokia's
> > > > > bootloader at *random* address. And U-Boot needed to be at fixed base
> > > > > address, therefore for N900 U-Boot low level init, there is a code which
> > > > > moves U-Boot itself from *random* address to fixed based.
> > > > 
> > > > OK, and that should still be there, so I guess you need to dig a bit
> > > > more to see what's wrong?
> > > 
> > > Yes, code is still there and seems it is working.
> > > 
> > > I just pointed that text comment, which was above CONFIG_SYS_TEXT_BASE
> > > define, is for CONFIG_SYS_TEXT_BASE. It is for lines 29-34:
> > > 
> > > http://git.denx.de/?p=u-boot.git;a=blob;f=include/configs/nokia_rx51.h;h=6312ed737c7104b331c11c8e88808fcc10654718;hb=6312ed737c7104b331c11c8e88808fcc10654718#l29
> > > 
> > > So when you moved definition for CONFIG_SYS_TEXT_BASE value, then you
> > > should have moved also comment which belongs to it :-)
> > 
> > Ah, but defconfig files are not for comments, they're generated files.
> > That should probably be in the README for the board.
> 
> There is already doc/README.nokia_rx51...

Right, and that comment belongs there now, or just removed if the README
explains that too.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181227/5a85e231/attachment.sig>