[U-Boot] [PATCH v3] net: phy: add TSE PCS support to dwmac-socfpga

[Ooi, Joyce]

> -----Original Message-----
> From: Marek Vasut [mailto:marex at denx.de]
> Sent: Friday, December 28, 2018 6:06 PM
> To: Ooi, Joyce <joyce.ooi at intel.com>; Joe Hershberger
> <joe.hershberger at ni.com>
> Cc: See, Chin Liang <chin.liang.see at intel.com>; Ong, Hean Loong
> <hean.loong.ong at intel.com>; Priyanka Jain <priyanka.jain at nxp.com>; u-
> boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH v3] net: phy: add TSE PCS support to dwmac-
> socfpga
> 
> On 12/28/18 7:57 AM, Ooi, Joyce wrote:
> >> -----Original Message-----
> >> From: Marek Vasut [mailto:marex at denx.de]
> >> Sent: Thursday, December 27, 2018 4:21 PM
> >> To: Ooi, Joyce <joyce.ooi at intel.com>; Joe Hershberger
> >> <joe.hershberger at ni.com>
> >> Cc: See, Chin Liang <chin.liang.see at intel.com>; Ong, Hean Loong
> >> <hean.loong.ong at intel.com>; Priyanka Jain <priyanka.jain at nxp.com>; u-
> >> boot at lists.denx.de
> >> Subject: Re: [U-Boot] [PATCH v3] net: phy: add TSE PCS support to
> >> dwmac- socfpga
> >>
> >> On 12/27/18 7:16 AM, Ooi, Joyce wrote:
> >>>> -----Original Message-----
> >>>> From: Marek Vasut [mailto:marex at denx.de]
> >>>> Sent: Thursday, December 27, 2018 2:55 AM
> >>>> To: Ooi, Joyce <joyce.ooi at intel.com>; Joe Hershberger
> >>>> <joe.hershberger at ni.com>
> >>>> Cc: See, Chin Liang <chin.liang.see at intel.com>; Ong, Hean Loong
> >>>> <hean.loong.ong at intel.com>; Priyanka Jain <priyanka.jain at nxp.com>;
> >>>> u- boot at lists.denx.de
> >>>> Subject: Re: [U-Boot] [PATCH v3] net: phy: add TSE PCS support to
> >>>> dwmac- socfpga
> >>>>
> >>>> On 12/26/18 8:47 AM, Ooi, Joyce wrote:
> >>>>> Adding Marek.
> >>>>>
> >>>>>> -----Original Message-----
> >>>>>> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
> >>>>>> Ooi, Joyce
> >>>>>> Sent: Tuesday, November 27, 2018 5:40 PM
> >>>>>> To: Joe Hershberger <joe.hershberger at ni.com>
> >>>>>> Cc: Ong, Hean Loong <hean.loong.ong at intel.com>; Priyanka Jain
> >>>>>> <priyanka.jain at nxp.com>; See, Chin Liang
> >>>>>> <chin.liang.see at intel.com>;
> >>>>>> u- boot at lists.denx.de
> >>>>>> Subject: Re: [U-Boot] [PATCH v3] net: phy: add TSE PCS support to
> >>>>>> dwmac- socfpga
> >>>>>>
> >>>>>> Hi Joe,
> >>>>>>
> >>>>>> Any comments/feedback on this v3 patch?
> >>>>
> >>>> I thought we already had TSE support in drivers/net/altera_tse.c ,
> >>>> is this related ?
> >>> drivers/net/altera_tse.c is a different IP, which contains of MAC
> >>> driver from Intel FPGA and PCS driver from Intel FPGA using MDIO PMA.
> >>>
> >>> This net/phy/altr_tse_pcs.c is the Physical Coding Sublayer for
> >>> DWMAC SGMII
> >> IP.
> >>> The DWMAC SGMII IP contains of MAC driver from DWMAC (Synopsis) and
> >>> PCS driver from Intel FPGA controlling Marvell PHY.
> >>
> >> Does this patch need to be split into two (three) patches then ?
> > This patch adds TSE PCS support to existing dwmac-socfpga.c and
> > designware.c, which adds a new file net/phy/altr_tse_pcs.c, while
> > dwmac-socfpga.c and designware.c call its functions. Hence, I didn't
> > split this implementation into several patches because I didn't want
> net/phy/altr_tse_pcs.c to appear like a dead code.
> >
> > If it's confusing, I could rename altr_tse_pcs.c to altr_dwmac_pcs.c,
> > since it is under DWMAC SGMII.
> 
> Is it a separate block which could be used by both Altera TSE and DWMAC or not
> ?
Yes, both Altera TSE and DWMAC can use it. Now that you mention it, I guess I'll
remain with altr_tse_pcs.c in case Altera TSE needs to enable SGMII in the future.
> 
> --
> Best regards,
> Marek Vasut