[U-Boot] [PATCH v2] rockchip: sdram-common: fix wrong size for 4GB in 32bit SoC

[Vagrant Cascadian]

On 2018-12-28, Kever Yang wrote:
> This is workaround for issue we can't get correct size for 4GB ram
> in 32bit system and available before we really need ram space
> out of 4GB, eg.enable ARM LAPE(rk3288 supports 8GB ram).
> The size of 4GB is '0x1 00000000', and this value will be truncated
> to 0 in 32bit system, and system can not get correct ram size.
> Rockchip SoCs reserve a blob of space for peripheral near 4GB,
> and we are now setting SDRAM_MAX_SIZE as max available space for
> ram in 4GB, so we can use this directly to workaround the issue.


U-Boot SPL 2019.01-rc2+dfsg-1~20181228~1 (Dec 28 2018 - 23:14:06 +0000)
Returning to boot ROM...


U-Boot 2019.01-rc2+dfsg-1~20181228~1 (Dec 28 2018 - 23:14:06 +0000)

Model: Firefly-RK3288
DRAM:  4 GiB
MMC:   dwmmc at ff0c0000: 1, dwmmc at ff0f0000: 0
Loading Environment from MMC... *** Warning - bad CRC, using default
environment

In:    serial
Out:   serial
Err:   serial
Model: Firefly-RK3288
Net:
Warning: ethernet at ff290000 (eth0) using random MAC address -
92:d3:c4:69:51:2c
eth0: ethernet at ff290000
Hit any key to stop autoboot:  0

And it boots! First time I've seen u-boot working on the firefly-rk3288
since ... v2018.01

Thanks for all the fixes everyone!

Tested-By: Vagrant Cascadian <vagrant at debian.org>

live well,
  vagrant

> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
>
> ---
>
> Changes in v2:
> - update the commit message and comment to show this is a workaround.
>
>  arch/arm/mach-rockchip/sdram_common.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/mach-rockchip/sdram_common.c b/arch/arm/mach-rockchip/sdram_common.c
> index 650d53e4d9..a27138083a 100644
> --- a/arch/arm/mach-rockchip/sdram_common.c
> +++ b/arch/arm/mach-rockchip/sdram_common.c
> @@ -48,6 +48,24 @@ size_t rockchip_sdram_size(phys_addr_t reg)
>  		      rank, col, bk, cs0_row, bw, row_3_4);
>  	}
>  
> +	/*
> +	 * This is workaround for issue we can't get correct size for 4GB ram
> +	 * in 32bit system and available before we really need ram space
> +	 * out of 4GB, eg.enable ARM LAPE(rk3288 supports 8GB ram).
> +	 * The size of 4GB is '0x1 00000000', and this value will be truncated
> +	 * to 0 in 32bit system, and system can not get correct ram size.
> +	 * Rockchip SoCs reserve a blob of space for peripheral near 4GB,
> +	 * and we are now setting SDRAM_MAX_SIZE as max available space for
> +	 * ram in 4GB, so we can use this directly to workaround the issue.
> +	 * TODO:
> +	 *   1. update correct value for SDRAM_MAX_SIZE as what dram
> +	 *   controller sees.
> +	 *   2. update board_get_usable_ram_top() and dram_init_banksize()
> +	 *   to reserve memory for peripheral space after previous update.
> +	 */
> +	if (size_mb > (SDRAM_MAX_SIZE >> 20))
> +		size_mb = (SDRAM_MAX_SIZE >> 20);
> +
>  	return (size_t)size_mb << 20;
>  }
>  
> -- 
> 2.20.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181228/2c24215a/attachment.sig>