[U-Boot] [PATCH v2] imx8mq_evk_defconfig: Move file system options to Kconfig

Fabio Estevam festevam at gmail.com
Sat Dec 29 12:02:24 UTC 2018


Chris Spencer reports that when enabling ext4 read support without
also enabling write support the following error is seen:

fs/fs.c:198:12: error: 'ext4_write_file' undeclared here (not in a
function); did you mean 'ext4_read_file'?
   .write = ext4_write_file,
            ^~~~~~~~~~~~~~~
Fix this problem by moving these options to Kconfig.

Reported-by: Chris Spencer <spencercw at gmail.com>
Acked-by: Peng Fan <peng.fan at nxp.com>
Signed-off-by: Fabio Estevam <festevam at gmail.com>
---
Changes since v1:
- Added missing y to CONFIG_CMD_FAT
 configs/imx8mq_evk_defconfig | 5 +++++
 include/configs/imx8mq_evk.h | 6 ------
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/configs/imx8mq_evk_defconfig b/configs/imx8mq_evk_defconfig
index f216d46a8f..b473fcd61b 100644
--- a/configs/imx8mq_evk_defconfig
+++ b/configs/imx8mq_evk_defconfig
@@ -15,6 +15,11 @@ CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL=y
 CONFIG_SPL_BOARD_INIT=y
 CONFIG_HUSH_PARSER=y
+CONFIG_DOS_PARTITION=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_CACHE=y
diff --git a/include/configs/imx8mq_evk.h b/include/configs/imx8mq_evk.h
index 35f81152f2..f0430224cb 100644
--- a/include/configs/imx8mq_evk.h
+++ b/include/configs/imx8mq_evk.h
@@ -226,12 +226,6 @@
 #define CONFIG_SYS_FSL_USDHC_NUM	2
 #define CONFIG_SYS_FSL_ESDHC_ADDR       0
 
-#define CONFIG_DOS_PARTITION
-#define CONFIG_CMD_EXT2
-#define CONFIG_CMD_EXT4
-#define CONFIG_CMD_EXT4_WRITE
-#define CONFIG_CMD_FAT
-
 #define CONFIG_SUPPORT_EMMC_BOOT	/* eMMC specific */
 #define CONFIG_SYS_MMC_IMG_LOAD_PART	1
 
-- 
2.17.1



More information about the U-Boot mailing list