[U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now

Simon Glass sjg at chromium.org
Sat Dec 29 13:16:41 UTC 2018


This function causes a 5-second delay and stops the display working on
minnie. This code should be in a driver and should only be enabled by
a device-tree property, so that it does not affect devices which do not
have this feature.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 arch/arm/mach-rockchip/boot_mode.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-rockchip/boot_mode.c b/arch/arm/mach-rockchip/boot_mode.c
index f32b3c4ce56..d7997d71e30 100644
--- a/arch/arm/mach-rockchip/boot_mode.c
+++ b/arch/arm/mach-rockchip/boot_mode.c
@@ -61,7 +61,13 @@ int setup_boot_mode(void)
 	void *reg = (void *)CONFIG_ROCKCHIP_BOOT_MODE_REG;
 	int boot_mode = readl(reg);
 
-	rockchip_dnl_mode_check();
+	/*
+	 * This should be handled using a driver-tree property and a suitable
+	 * driver which can read the appropriate settings. As it is, this
+	 * breaks chromebook_minnie.\
+	 *
+	 * rockchip_dnl_mode_check();
+	 */
 
 	boot_mode = readl(reg);
 	debug("%s: boot mode 0x%08x\n", __func__, boot_mode);
-- 
2.20.1.415.g653613c723-goog



More information about the U-Boot mailing list