[U-Boot] [PATCH v3 4/8] dm: pinctrl: Add pinctrl_decode_pin_config_dm().

Simon Glass sjg at chromium.org
Sat Dec 29 13:39:38 UTC 2018


Hi Christoph,

On Tue, 25 Dec 2018 at 14:49, Christoph Müllner
<christoph.muellner at theobroma-systems.com> wrote:
>
> On 12/20/18 10:16 PM, Simon Glass wrote:
> > Hi Christoph,
> >
> > On Mon, 17 Dec 2018 at 06:30, Christoph Muellner
> > <christoph.muellner at theobroma-systems.com> wrote:
> >>
> >> pinctrl_decode_pin_config_dm() is basically a feature-equivalent
> >> implementation of pinctrl_decode_pin_config(), which operates
> >> on struct udevice devices and uses the dev_read_*() API.
> >
> > So is it possible to remove the old function and avoid the _dm suffix here?
>
> Seems like the right way to go for me.
> But I don't have the option to test on devices, which
> need this function (RK3188 and RK3288) and I don't want
> to risk touching drivers, which I cannot test outside
> of the regular merge window.
>
> My plan was to do this early during the next merge window
> (together with dropping the old RK3399 pinctrl driver and
> the refactoring of the RK3399 pinctrl driver into a generic
> RK pinctrl driver and a RK3399 mini-driver).
>
> Acceptable?

Yes that's fine with me. Could you add a comment saying that this
function is temporary for this release and will be removed in patches
by February?

Regards,
Simon


More information about the U-Boot mailing list