[U-Boot] [PATCH 1/4] fs: cbfs: remove wrong header validation

Simon Glass sjg at chromium.org
Sat Dec 29 13:39:50 UTC 2018


On Sat, 22 Dec 2018 at 02:50, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> From: Christian Gmeiner <christian.gmeiner at gmail.com>
>
> cbfs_fileheader.len indicates the content size of the file in the
> cbfs, and it has nothing to do with cbfs_fileheader.offset which
> is the starting address of the file in the cbfs.
>
> Remove such check in file_cbfs_next_file(). Before this change
> 'cbfsinit' failed with 'Bad CBFS file'. After this change all cbfs
> commands are working as expected.
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
> [bmeng: keep the necessary header sanity check]
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>
> ---
>
>  fs/cbfs/cbfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list