[U-Boot] [linux-sunxi] [PATCH] Revert "sunxi: board: Print error after power initialization fails"

[Olliver Schinagl]

Luckily we have had no problem with this on our boards, but its sad to see this patch reverted due to the buggy ddr implementation ...

Curiosity is getting the better of me and I cant seem to be able to reproduce the problem. So could you be a little bit more specific on the bug please?

On December 29, 2018 7:53:49 PM GMT+01:00, Jagan Teki <jagan at amarulasolutions.com> wrote:
>On Wed, Dec 19, 2018 at 6:32 PM Andre Przywara <andre.przywara at arm.com>
>wrote:
>>
>> From: "From: Karl Palsson" <karlp at tweak.net.au>
>>
>> Commit a8011eb84dfa("sunxi: board: Print error after power
>initialization
>> fails") moved the DRAM init after the increase of the CPU clock
>> frequency. This lead to various DRAM initialisation failures on some
>> boards (hangs or wrong size reported, on a NanoPi Duo2 and OrangePi
>> Zero, for instance). Lowering the CPU frequency significantly (for
>instance
>> to 408 MHz) seems to work around the problem, so this points to some
>timing
>> issues in the DRAM code.
>>
>> Debugging this sounds like a larger job, so let's just revert this
>patch
>> to bring back those boards.
>> Beside this probably unintended change the patch just moved the error
>> message around, so reverting this is not a real loss.
>
>Better mark this as TODO somewhere, may be some one look it later.
>
>>
>> This reverts commit a8011eb84dfac5187cebf00ed8bc981bdb5c1fa1.
>>
>> Tested-By: Priit Laes <plaes at plaes.org>
>> Signed-off-by: Karl Palsson <karlp at tweak.net.au>
>> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
>
>Applied to u-boot-sunxi/master

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.