[U-Boot] [PATCH 3/4] Kconfig: gadget: Move CONFIG_USB_FUNCTION_MASS_STORAGE to Kconfig

[Maxime Ripard]

On Tue, Jan 30, 2018 at 10:08:50AM +0100, Lukasz Majewski wrote:
> Hi Maxime,
> 
> > Hi,
> > 
> > On Mon, Jan 29, 2018 at 07:25:54PM +0100, Lukasz Majewski wrote:
> > > This commit moves USB_FUNCTION_MASS_STORAGE config to Kconfig.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma at denx.de>
> > > ---
> > > 
> > >  configs/Bananapi_m2m_defconfig                 | 1 +
> > >  configs/CHIP_pro_defconfig                     | 1 +
> > >  configs/Nintendo_NES_Classic_Edition_defconfig | 1 +
> > >  configs/Sinlinx_SinA33_defconfig               | 1 +  
> > 
> > Please make that a default for sunxi instead of crippling our
> > defconfigs.
> 
> Could you be more specific here?

Add an equivalent to the
#ifdef CONFIG_USB_MUSB_GADGET
#define CONFIG_USB_FUNCTION_MASS_STORAGE
#endif

That was there before, and isn't there anymore. Something like
default y if ARCH_SUNXI && USB_MUSB_GADGET

> I've used moveconfig.py script to check which board has this define in
> its *.h config file.
> Then, it was moved to proper defconfig for this board.
> 
> Hence, I don't understand why I "cripple" your (sunxi) defconfig(s)?
> 
> If this is the case - I can "select" this option for all sunxi devices,
> so all of them would have UMS function enabled.

We're always trying to keep the defconfig as free of boilerplate as
possible, since we have so many of them. And people just keep adding
more and more and more boilerplate options, that's all...

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180201/3cedd142/attachment.sig>