[U-Boot] [PATCH] board_f: Show only .text location in display_text_info()

Simon Glass sjg at chromium.org
Thu Feb 1 19:32:16 UTC 2018


Hi Alexey,

On 1 February 2018 at 10:33, Alexey Brodkin <Alexey.Brodkin at synopsys.com> wrote:
>
> For some reason we used to print not only location of .text
> section [before relocation] but also .bss start and end.
>
> Moreover how that was printed was obviously misleading:
> --------------------------------->8---------------------------
> U-Boot code: 20001000 -> 30008C00  BSS: -> 3000C58E
> --------------------------------->8---------------------------
>
> I would interpret it like this:
>   U-Boot's code is situated in memory starting from 0x20001000
>   till 0x30008000.. and BTW there's .bss section starting from 0x3000C58E.
>
> Which is wrong. But anyways why bother about .bss here so let's
> drop .bss part in that pure debug output.
>
> Note even though this change has logically nothing in common with [1]
> they both touch the same function display_text_info() which makes [1]
> a prerequisite for this one. Otherwise trivial modifications will be
> required in both if they happen to be reordered.
>
> [1] http://patchwork.ozlabs.org/patch/868299/
>
> Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Tom Rini <trini at konsulko.com>
> ---
>  common/board_f.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)

I think it is sometimes useful to print BSS. I have had problems with
it overlapping (e.g.) the DT. Can you just fix the output?

Regards,
Simon


More information about the U-Boot mailing list