[U-Boot] [PATCH v2] sandbox: Add 64-bit sandbox

Simon Glass sjg at chromium.org
Sun Feb 4 12:34:15 UTC 2018


Hi Mario,

On 26 January 2018 at 14:43, Simon Glass <sjg at chromium.org> wrote:
> On 19 January 2018 at 00:17, Mario Six <mario.six at gdsys.cc> wrote:
>> From: Mario Six <six at gdsys.cc>
>>
>> To debug device tree issues involving 32- and 64-bit platforms, it is useful to
>> have a generic 64-bit platform available.
>>
>> Add a version of the sandbox that uses 64-bit integers for its physical
>> addresses as well as a modified device tree.
>>
>> Signed-off-by: Mario Six <mario.six at gdsys.cc>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>> v1 -> v2:
>> * Renamed CONFIG_SANDBOX_64BIT to CONFIG_HOST_64BIT to make semantics more
>>   easily understandable
>> * Switched control of integer width to depend on CONFIG_PHYS_64BIT instead of
>>   CONFIG_SANDBOX64
>> * Extended the sandbox README with information about the 64-bit sandbox
>>
>> ---
>>  arch/sandbox/Kconfig             |  16 +-
>>  arch/sandbox/cpu/cpu.c           |   2 +-
>>  arch/sandbox/dts/Makefile        |   4 +
>>  arch/sandbox/dts/sandbox64.dts   | 317 +++++++++++++++++++++++++++++++++++++++
>>  arch/sandbox/include/asm/io.h    |   6 +
>>  arch/sandbox/include/asm/types.h |  17 ++-
>>  board/sandbox/README.sandbox     |   7 +-
>>  cmd/demo.c                       |   6 +-
>>  configs/sandbox64_defconfig      | 200 ++++++++++++++++++++++++
>>  drivers/demo/demo-simple.c       |   2 +-
>>  10 files changed, 561 insertions(+), 16 deletions(-)
>>  create mode 100644 arch/sandbox/dts/sandbox64.dts
>>  create mode 100644 configs/sandbox64_defconfig
>
> Applied to u-boot-dm, thanks!

Unfortunately I had to drop this as it caused warnings when building:

lib/fdtdec.c: In function ‘fdtdec_get_addr_size_auto_noparent’:
include/fdtdec.h:27:25: warning: large integer implicitly truncated to
unsigned type [-Woverflow]
 #define FDT_ADDR_T_NONE (-1ULL)

Would you please take a look? Also can you add a MAINTAINER file for
sandbox/sandbox64?

Sorry for the late notice.

Thanks,
Simon


More information about the U-Boot mailing list