[U-Boot] [PATCH v3 1/3] drivers/ddr/fsl: Fix DDR4 RDIMM support

Simon Glass sjg at chromium.org
Sun Feb 4 13:39:44 UTC 2018


Hi York,

On 24 January 2018 at 12:04, York Sun <york.sun at nxp.com> wrote:
> For DDR4, command/address delay in mode registers and parity latency
> in timing config register are only needed for UDIMMs, but not RDIMMs.
> Add additional register rcw_3 for DDR4 RDIMM. Fix mirrored bit for
> dual rank RDIMMs. Set sdram_cfg_3[DIS_MRS_PAR] for RDIMMs. Use
> hexadecimal format for printing RCW (register control word) registers.
>
> Signed-off-by: York Sun <york.sun at nxp.com>
> ---
>
> Changes in v3: None
> Changes in v2: None
>
>  drivers/ddr/fsl/ctrl_regs.c        | 32 +++++++++++++++++++++++++-------
>  drivers/ddr/fsl/ddr4_dimm_params.c |  2 ++
>  drivers/ddr/fsl/interactive.c      |  9 +++++++--
>  include/fsl_ddr_sdram.h            |  1 +
>  4 files changed, 35 insertions(+), 9 deletions(-)

What do you think about moving this into drivers/ram (separate from
this patch)? Do you think it could use the uclass?

Regards,
Simon


More information about the U-Boot mailing list