[U-Boot] [PATCH] usb: dwc2: make casts of ep->dma_buf consistent
Marek Vasut
marex at denx.de
Mon Feb 5 14:56:42 UTC 2018
On 02/05/2018 03:54 PM, Tom Rini wrote:
> In most places in the code we cast this to an unsigned long, but in one
> place we cast to an unsigned int. For consistency and to fix a warning
> on 64bit targets, always cast this to unsigned long. For the long term
> we should however change the declaration of dma_buf.
>
> Cc: Lukasz Majewski <lukma at denx.de>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> index b6164afa9245..57dbbd5ebfa1 100644
> --- a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> +++ b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> @@ -114,7 +114,7 @@ static int setdma_rx(struct dwc2_ep *ep, struct dwc2_request *req)
> (unsigned long) ep->dma_buf +
> ROUND(ep->len, CONFIG_SYS_CACHELINE_SIZE));
>
> - writel((unsigned int) ep->dma_buf, ®->out_endp[ep_num].doepdma);
> + writel((unsigned long) ep->dma_buf, ®->out_endp[ep_num].doepdma);
> writel(DOEPT_SIZ_PKT_CNT(pktcnt) | DOEPT_SIZ_XFER_SIZE(length),
> ®->out_endp[ep_num].doeptsiz);
> writel(DEPCTL_EPENA|DEPCTL_CNAK|ctrl, ®->out_endp[ep_num].doepctl);
>
Acked-by: Marek Vasut <marex at denx.de>
--
Best regards,
Marek Vasut
More information about the U-Boot
mailing list