[U-Boot] [PATCH v2 1/3] Move CONFIG_PHY_ADDR to Kconfig

[Tom Rini]

On Mon, Feb 05, 2018 at 09:07:40AM +0100, Maxime Ripard wrote:
> On Sat, Feb 03, 2018 at 04:37:15AM +0000, Calvin Johnson wrote:
> > > Hi,
> > > 
> > > > From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Stefan
> > > > Mavrodiev
> > > > Sent: Friday, February 2, 2018 7:24 PM
> > > 
> > > <snip>
> > > 
> > > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index
> > > > 95b7534..c934aed 100644
> > > > --- a/drivers/net/phy/Kconfig
> > > > +++ b/drivers/net/phy/Kconfig
> > > > @@ -12,6 +12,13 @@ menuconfig PHYLIB
> > > >
> > > >  if PHYLIB
> > > >
> > > > +config PHY_ADDR
> > > > +	int "PHY address"
> > > > +	default 1 if ARCH_SUNXI
> > 
> > Sorry, I meant the  default value can be defined in board/sunxi/Kconfig.
> > Remaining definition of PHY_ADDR config can be here.
> 
> Tom has asked a few times not to do this but to put the defaults where
> the Kconfig option is defined. I'm not sure I remember the details
> though.

For now, yes, the preferred way of dealing with this is 'default FOO if
BAR' in the main Kconfig entry line.  What I wish for long term is for
'imply' to get extended to support 'imply FOO BAR' but I've not had more
to add there other than "Gee, this would make life easier".

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180205/a25979bb/attachment.sig>