[U-Boot] usb: ulpi: kconfig: Remove meaningless choice default

Tom Rini trini at konsulko.com
Tue Feb 6 01:58:57 UTC 2018


On Tue, Jan 30, 2018 at 02:07:05PM +0100, Ulf Magnusson wrote:

> 'default' on a choice refers to the symbol selected by default, not to
> the choice mode, so 'default n' is meaningless.
> 
> No functional changes. Optional choices implicitly default to n mode
> (and there is no way to make them default to another mode).
> 
> Discovered in Kconfiglib (https://github.com/ulfalizer/Kconfiglib),
> which prints the following warning:
> 
> 	warning: the default selection n (undefined) of <choice> (defined at drivers/usb/ulpi/Kconfig:3) is not contained in the choice
> 
> I've added a corresponding warning to the C tools too, which is
> currently in linux-next: https://patchwork.kernel.org/patch/9983667/
> 
> Signed-off-by: Ulf Magnusson <ulfalizer at gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180205/8609813a/attachment.sig>


More information about the U-Boot mailing list