[U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

Maxime Ripard maxime.ripard at bootlin.com
Wed Feb 7 08:31:43 UTC 2018


On Mon, Feb 05, 2018 at 04:30:50PM +0000, York Sun wrote:
> On 02/05/2018 05:44 AM, Maxime Ripard wrote:
> > Hi York,
> > 
> > On Fri, Feb 02, 2018 at 08:04:12PM +0000, York Sun wrote:
> >> On 02/02/2018 10:51 AM, Maxime Ripard wrote:
> >>>>> This patch looks correct. But it doesn't fix NOR flash. Do you have plan
> >>>>> to add .get_char function to other drivers? Without that function, we
> >>>>> cannot get env variables before relocation.
> >>>>
> >>>> Ehrm, sorry  I don't plan to do that, no: my target seems to run fine
> >>>> without this.
> >>>>
> >>>> Given that only the eeprom and nvram env drivers support the get_char
> >>>> method, I don't know if this is widely used at all. Maybe a better fallback
> >>>> would be to just remove that get_char code path totally and always load from
> >>>> the internal (default) environment until the full environment is available
> >>>> (after relocation).
> >>>>
> >>>> After all, the environment variables loaded via get_char are not CRC checked
> >>>> at all. To me, this is another indication that this code is not really
> >>>> useful and should probably be removed.
> >>>
> >>> To be honest, I'm not really sure what get_char was here for in the
> >>> first place, so getting rid of it sounds like a good idea :)
> >>
> >> On almost all my boards, a variable hwconfig is read before relocation
> >> to determine DDR configuration. This has been broken. I don't mind you
> >> remove some dead code. But this is breaking almost all my boards booting
> >> from NOR flash.
> > 
> > Sorry if it fell through the cracks, I don't have a board with NOR
> > myself. Do you know what breaks exactly?
> > 
> > Or can you bisect at least?

> Yes, I did. It was the #3 patch in the series of "env: Multiple env
> support and env transition for sunxi". I reported in the email thread
> "Re: [U-Boot] [PATCH v3 09/15] env: Support multiple environments",
> along with another problem found regarding variable "env_load_location".
> The latter problem breaks saveenv on NOR flash.

Ah, right, I overlooked it, sorry.

I'll reply there.

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180207/08f1b11d/attachment.sig>


More information about the U-Boot mailing list