[U-Boot] [PATCH] Fix --noheader on fw_printenv

Alex Kiernan alex.kiernan at gmail.com
Thu Feb 8 16:17:02 UTC 2018


On Thu, Feb 8, 2018 at 3:37 PM,  <stefan at agner.ch> wrote:
> On 08.02.2018 10:35, Alex Kiernan wrote:
>> Using fw_printenv with --noheader fails:
>>
>>   root at nrr-922:~# fw_printenv --noheader arch
>>   ## Error: `-n' option requires exactly one argument
>
> I think it would work with --noheader=arch
>

It doesn't:

root at nrr-922:~# fw_printenv --noheader=arch
## Error: `-n' option requires exactly one argument

Probably I should fix the error too as it's misleading.

>>
>> Whereas -n works:
>>
>>   root at nrr-922:~# fw_printenv -n arch
>>   arm
>>
>> The single argument it's expecting isn't taken from getopt parsing,
>> but instead from the remaining argv arguments.
>
> That makes sense. But the commit log text above is kind of unrelated/not
> relevant, I would just use this two lines as git message.
>

Happy to chop it down to the last two lines though as it does include
the relevant details.

-- 
Alex Kiernan


More information about the U-Boot mailing list