[U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc

Marek Vasut marex at denx.de
Mon Feb 12 15:40:49 UTC 2018


On 02/12/2018 04:39 PM, Lukasz Majewski wrote:
> Hi Simon, Marek,
> 
>> On 02/12/2018 04:16 PM, Simon Goldschmidt wrote:
>>> On 12.02.2018 15:54, Marek Vasut wrote:  
>>>> On 02/12/2018 03:52 PM, Simon Goldschmidt wrote:  
>>>>> In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some
>>>>> thins for spi flash and mmc that are not required by the hw.  
>>>> things ?
>>>>
>>>> what hw, all supported boards you mean ?
>>>>  
>>>>> Give users more freedom of choice and use imply here instead
>>>>> of select.
>>>>>
>>>>> This should allow disabling spi support completely or using
>>>>> sd/mmc boot in "raw mode" (no partitions).  
>>>> You can just turn them off in the defconfigs, but I get what you're
>>>> trying to say.
>>>>
>>>> Just reword the commit message and do make savedefconfig for all
>>>> the socfpga platforms (in a separate patch) to sync the defconfigs
>>>> up.  
>>>
>>> OK, thanks. Given that the same files are touched, should I wait
>>> for the CONFIG_HW_WATCHDOG patches from Lukasz to be applied
>>> first?  
>>
>> You two figure it out :)
> 
> It is always better to ask socfpga veteran for his opinion :-)

SoCFPGA veteran is old and is delegating tasks ;-)

> Simon, feel free to perform the clean up. I will have to look more
> closely to the WDT move to Kconfig.
> 
> Even better, you are more than welcome to use/squash this patch to your
> work:
> http://patchwork.ozlabs.org/patch/871578/
> 
> It will simplify my WDT conversion work.

Good!

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list