[U-Boot] [PATCH v2 2/2] efi_loader: rewrite README.efi

Alexander Graf agraf at suse.de
Mon Feb 12 19:41:18 UTC 2018



> Am 12.02.2018 um 15:35 schrieb Simon Glass <sjg at chromium.org>:
> 
> Hi Alex,
> 
>> On 9 February 2018 at 11:55, Alexander Graf <agraf at suse.de> wrote:
>> 
>> 
>>> On 30.01.18 20:03, Heinrich Schuchardt wrote:
>>> Provide information about
>>> 
>>> - usage of the bootefi command
>>> - overview of UEFI
>>> - interaction between U-Boot and EFI drivers
>>> 
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>>> ---
>>> v2
>>>      new file
>> 
>> The patch is very hard to read. Please just make this 2 patches. One
>> that removes the old file, one that adds the rewrite.
> 
> That doesn't make a lot of sense to me. Can you not just apply the
> patch locally and read it?

That‘s what I did, but I doubt the occasional reviewer does it. He also rewrites the file completely, even changing copyright. So IMHO remove+add is the better way to express what is happening here.

Alex




More information about the U-Boot mailing list