[U-Boot] [PATCH] drivers/ddr/fsl: Dual-license DDR driver

Tue Feb 13 17:43:43 UTC 2018

On 02/13/2018 05:30 PM, York Sun wrote:
> On 02/13/2018 04:49 AM, Wolfgang Denk wrote:
>> Dear York,
>>
>> In message <VI1PR04MB20785EF7D2578E39C048EE219AF70 at VI1PR04MB2078.eurprd04.prod.outlook.com> you wrote:
>>>
>>> Nobody said anything. Some addresses bounced. And most changes made out
>>> people outside Freescale/NXP are minor changes, except twice the files
>>> were moved during U-Boot structure change. What options do I have?
>>
>> Ask all people who contributed to that code for their explicit
>> permission.  Legally it is a huge difference between actively
>> confirming approval and not reacting at all.
>>
> 
> 
> All,
> 
> If you haven't responded, please give your explicit approval to change
> Freescale DDR driver to dual-license so it can be re-used by other
> project(s) with BSD license. Here is the list I compiled from the git
> history. All commits made by Freescale/NXP employees are removed from
> this list.
> 
> 
> 00caae6 - Simon Glass, sjg at chromium.org, 6 months ago : env: Rename
> getenv/_f() to env_get()
> 457e51c - Simon Glass, sjg at chromium.org, 9 months ago : common: arm:
> freescale: layerscape: Move header files out of common.h
> 6e2941d - Simon Glass, sjg at chromium.org, 9 months ago : common:
> freescale: Move arch-specific declarations
> 3c476d8 - Tom Rini, trini at konsulko.com, 10 months ago : Merge
> git://git.denx.de/u-boot-fsl-qoriq
> 0e0de24 - xypron.glpk at gmx.de, xypron.glpk at gmx.de, 10 months ago : ddr:

A single line correction certainly does not deserve copyright. So I
won't stop this change.

I can understand that NXP wants to save double work. In general I prefer
GPL as a license for U-Boot because it requires that source code changes
are made available on request.

Regards

Heinrich

> fsl: incorrect logical constraint in populate_memctl_options
> 97fbf26 - Thomas Schaefer, thomas.schaefer at kontron.com, 11 months ago :
> drivers: ddr: fsl: fix unused-const-variable warnings
> f1683aa - Simon Glass, sjg at chromium.org, 10 months ago : board_f: Rename
> initdram() to dram_init()
> 3eace37 - Simon Glass, sjg at chromium.org, 10 months ago : arm: freescale:
> Rename initdram() to fsl_initdram()
> 088454c - Simon Glass, sjg at chromium.org, 11 months ago : board_f: Drop
> return value from initdram()
> cbe7706 - Tom Rini, trini at konsulko.com, 1 year, 5 months ago : Merge
> git://git.denx.de/u-boot-fsl-qoriq
> a4ca379 - Masahiro Yamada, yamada.masahiro at socionext.com, 1 year, 5
> months ago : drivers: squash lines for immediate return
> 62a3b7d - Robert P. J. Day, rpjday at crashcourse.ca, 1 year, 7 months ago
> : Various, unrelated tree-wide typo fixes.
> dd8d8da - Alexander Merkle, alexander.merkle at lauterbach.com, 1 year, 11
> months ago : Fix typo choosen in comments and printf logs
> 5b8031c - Tom Rini, trini at konsulko.com, 2 years, 1 month ago : Add more
> SPDX-License-Identifier tags
> da58dec - Tom Rini, trini at konsulko.com, 2 years, 3 months ago : Various
> Makefiles: Add SPDX-License-Identifier tags
> e368c20 - Joakim Tjernlund, joakim.tjernlund at transmode.se, 2 years, 4
> months ago : drivers/ddr/fsl_ddr: Make SR_IE configurable
> d7c865b - Curt Brune, curt at cumulusnetworks.com, 3 years ago :
> MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register
> b414119 - Masahiro Yamada, yamada.m at jp.panasonic.com, 3 years, 3 months
> ago : linux/kernel.h: sync min, max, min3, max3 macros with Linux
> e1bf824 - Simon Glass, sjg at chromium.org, 3 years, 10 months ago : Add
> cli_ prefix to readline functions
> 18d6653 - Simon Glass, sjg at chromium.org, 3 years, 10 months ago : move
> CLI prototypes to cli.h and add comments
> 06c1411 - Masahiro Yamada, yamada.m at jp.panasonic.com, 4 years, 4 months
> ago : powerpc: convert makefiles to Kbuild style
> 7e157b0 - Valentin Longchamp, valentin.longchamp at keymile.com, 4 years, 4
> months ago : mpc8xxx: set x2 DDR3 refresh rate if SPD config requires it
> 0778bbe - Valentin Longchamp, valentin.longchamp at keymile.com, 4 years, 4
> months ago : mpc8xxx: call i2c_set_bus_num in __get_spd
> 2f848f9 - Shruti Kanetkar, Shruti at Freescale.com, 4 years, 6 months ago :
> powerpc: Use print_size() where appropriate
> 1a45966 - Wolfgang Denk, wd at denx.de, 4 years, 7 months ago : Add
> GPL-2.0+ SPDX-License-Identifier to source files
> 5b93394 - Anatolij Gustschin, agust at denx.de, 5 years ago : mpc8xxx: fix
> DDR init value to use CONFIG_MEM_INIT_VALUE
> 411e150 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning
> 2f3a71f - Ira W. Snyder, iws at ovro.caltech.edu, 6 years ago : mpc8xxx:
> update module_type values from JEDEC DDR3 SPD Specification
> dea7f88 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c: Fix GCC 4.6 build warning
> 667bc17 - Kumar Gala, galak at kernel.crashing.org, 6 years ago :
> arch/powerpc/cpu/mpc8xxx/ddr/options.c: Fix GCC 4.6 build warning
> cd84b1f - Marek Vasut, marek.vasut at gmail.com, 6 years ago : GCC4.6:
> Squash warnings in ddr[123]_dimm_params.c
> a287963 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> fsl-ddr: Fix mixed-case macro names
> c2a63f4 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Fix typo for address hashing message
> c7fd27c - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> mpc8xxx: DDR2/DDR3: Clean up DIMM-type switch statements
> e820a13 - Kyle Moffett, Kyle.D.Moffett at boeing.com, 7 years ago :
> fsl_ddr: Don't use full 64-bit divides on 32-bit PowerPC
> c39f44d - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Refactor fsl_ddr_get_spd into common code from board
> 5df4b0a - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Replace fsl_ddr_get_mem_data_rate with get_ddr_freq()
> 9296683 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Fix compile warning when build for a DDR1 or DDR2 board
> dd50af2 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Add hwconfig APIs to address early parsing used by DDR init
> 3dbd5d7 - Kumar Gala, galak at kernel.crashing.org, 7 years ago :
> powerpc/8xxx: Move fsl_is_spd() into generic 8xxx ddr code
> 7ea3871 - Becky Bruce, beckyb at kernel.crashing.org, 7 years ago : MPC8xxx
> DDR: align informational prints
> 6d8962e - Sebastien Carlier, sebastien.carlier at gmail.com, 7 years ago :
> Switch from archive libraries to partial linking
> 79e4e64 - Kumar Gala, galak at kernel.crashing.org, 8 years ago :
> powerpc/8xxx: Enabled hwconfig for memory interleaving
> a47a12b - Stefan Roese, sr at denx.de, 8 years ago : Move arch/ppc to
> arch/powerpc
> 8d1f268 - Peter Tyser, ptyser at xes-inc.com, 8 years ago : ppc: Move
> cpu/$CPU to arch/ppc/cpu/$CPU
> 
> Thanks.
> 
> York
> 