[U-Boot] [PATCH 1/1] fs: fat: avoid useless conversion when calling getcluster

[Lukasz Majewski]

On Tue, 13 Feb 2018 19:18:58 +0100
Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:

> Parameter size of function get_cluster() is of type unsigned long. It
> makes no sense to convert actsize to int before passing it to
> get_cluster as size.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  fs/fat/fat.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/fat/fat.c b/fs/fat/fat.c
> index dd7888cd6d4..a3c7bf604eb 100644
> --- a/fs/fat/fat.c
> +++ b/fs/fat/fat.c
> @@ -353,7 +353,7 @@ static int get_contents(fsdata *mydata, dir_entry
> *dentptr, loff_t pos, if (pos) {
>  		actsize = min(filesize, (loff_t)bytesperclust);
>  		if (get_cluster(mydata, curclust,
> get_contents_vfatname_block,
> -				(int)actsize) != 0) {
> +				(unsigned long)actsize) != 0) {
>  			printf("Error reading cluster\n");
>  			return -1;
>  		}
> @@ -393,14 +393,16 @@ static int get_contents(fsdata *mydata,
> dir_entry *dentptr, loff_t pos, 
>  		/* get remaining bytes */
>  		actsize = filesize;
> -		if (get_cluster(mydata, curclust, buffer,
> (int)actsize) != 0) {
> +		if (get_cluster(mydata, curclust, buffer,
> +				(unsigned long)actsize) != 0) {
>  			printf("Error reading cluster\n");
>  			return -1;
>  		}
>  		*gotsize += actsize;
>  		return 0;
>  getit:
> -		if (get_cluster(mydata, curclust, buffer,
> (int)actsize) != 0) {
> +		if (get_cluster(mydata, curclust, buffer,
> +				(unsigned long)actsize) != 0) {
>  			printf("Error reading cluster\n");
>  			return -1;
>  		}

Reviewed-by: Lukasz Majewski <lukma at denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180213/76aa2778/attachment.sig>