[U-Boot] [PATCH v8 3/4] cmd: ubifs: Factor out some checking codes into cmd_ubifs_mount()

Marek Vasut marex at denx.de
Thu Feb 15 14:59:03 UTC 2018


On 02/05/2018 08:06 AM, tien.fong.chee at intel.com wrote:
> From: Tien Fong Chee <tien.fong.chee at intel.com>
> 
> cmd_ubifs_mount() function would be called directly instead of
> involving whole command machinery for mounting ubifs in
> generic firmware loader, so some checking codes need to be factored out
> into cmd_ubifs_mount() without breaking original functionality design.
> 
> Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>

[...]

> diff --git a/include/ubi_uboot.h b/include/ubi_uboot.h
> index 827dbfc..fb300e8 100644
> --- a/include/ubi_uboot.h
> +++ b/include/ubi_uboot.h
> @@ -76,5 +76,6 @@ extern int ubi_volume_read(char *volume, char *buf, size_t size);
>  
>  extern struct ubi_device *ubi_devices[];
>  int cmd_ubifs_umount(void);
> +int cmd_ubifs_mount(char *vol_name);

Swap these two -- mount first and umount seconds.

With that
Reviewed-by: Marek Vasut <marex at denx.de>

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list