[U-Boot] [PATCH] mmc: Fix uninitialised priv member

Jaehoon Chung jh80.chung at samsung.com
Mon Feb 19 11:23:52 UTC 2018


On 02/10/2018 12:24 AM, Alex Kiernan wrote:
> When using omap_hsmmc without the device model then the allocation
> of mmc->priv ends up uninitialised.
> 
> Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>

Applied to u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

> ---
> I've a board (AM335xx based) which boots fine with 2018-01, with
> 2018-03-rc1 (actually 1811a92) it fails in the MLO:
> 
>   U-Boot SPL 2018.03-rc1-00222-g128a503-dirty (Feb 09 2018 - 11:51:50 +0000)
>   Trying to boot from MMC2
>   omap_hsmmc_send_cmd : DMA timeout: No status update
>   mmc_init: -110, time 1026
>   spl: mmc init failed with error: -110
>   SPL: failed to boot from all boot devices
>   ### ERROR ### Please RESET the board ###
> 
> Bisecting it out, it's this commit:
> 
>   f0d53e8 mmc: omap_hsmmc: Add support for DMA (ADMA2)
> 
>  drivers/mmc/omap_hsmmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
> index b12d6d9..c6b3f25 100644
> --- a/drivers/mmc/omap_hsmmc.c
> +++ b/drivers/mmc/omap_hsmmc.c
> @@ -918,7 +918,7 @@ int omap_mmc_init(int dev_index, uint host_caps_mask, uint f_max, int cd_gpio,
>  	struct mmc_config *cfg;
>  	uint host_caps_val;
>  
> -	priv = malloc(sizeof(*priv));
> +	priv = calloc(1, sizeof(*priv));
>  	if (priv == NULL)
>  		return -1;
>  
> 



More information about the U-Boot mailing list