[U-Boot] [PATCH v2 16/20] sunxi: dts: enable NAND on NES classic

[Maxime Ripard]

Hi,

On Thu, Feb 22, 2018 at 02:33:46PM +0100, Miquel Raynal wrote:
> Let the Nintendo NES Classic use the Macronix NAND chip on it.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> ---
>  arch/arm/dts/sun8i-a23-a33.dtsi                        | 18 ++++++++++++++++++
>  .../arm/dts/sun8i-r16-nintendo-nes-classic-edition.dts | 14 ++++++++++++++
>  2 files changed, 32 insertions(+)
> 
> diff --git a/arch/arm/dts/sun8i-a23-a33.dtsi b/arch/arm/dts/sun8i-a23-a33.dtsi
> index ea50dda75a..c0053ad649 100644
> --- a/arch/arm/dts/sun8i-a23-a33.dtsi
> +++ b/arch/arm/dts/sun8i-a23-a33.dtsi
> @@ -289,6 +289,24 @@
>  				function = "uart1";
>  			};
>  
> +			nand_pins_a: nand-base0 at 0 {
> +				allwinner,pins = "PC0", "PC1", "PC2",
> +				"PC5", "PC8", "PC9", "PC10",
> +				"PC11", "PC12", "PC13", "PC14",
> +				"PC15";
> +				allwinner,function = "nand0";
> +			};
> +
> +			nand_cs0_pins_a: nand-cs at 0 {
> +				allwinner,pins = "PC4";
> +				allwinner,function = "nand0";
> +			};
> +
> +			nand_rb0_pins_a: nand-rb at 0 {
> +				allwinner,pins = "PC6";
> +				allwinner,function = "nand0";
> +			};
> +

This is the old-style binding that is now deprecated, you should
favour the new one (with function and pins instead of
allwinner,function and allwinner,pins).

The indentation of the nand pins in your first group is weird too.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180222/a98e708c/attachment.sig>