[U-Boot] [PATCH 1/2] arm: socfpga: cyclone5: Enable Macronix flash support

[Marek Vasut]

On 02/22/2018 02:39 PM, See, Chin Liang wrote:
> On Thu, 2018-02-22 at 11:45 +0100, Marek Vasut wrote:
>> On 02/22/2018 07:29 AM, See, Chin Liang wrote:
>>>
>>> On Wed, 2018-02-21 at 20:23 +0100, Marek Vasut wrote:
>>>>
>>>> On 02/21/2018 08:39 AM, chin.liang.see at intel.com wrote:
>>>>>
>>>>>
>>>>> From: Chin Liang See <chin.liang.see at intel.com>
>>>>>
>>>>> Enable Macronix flash support for Cyclone5 SoC
>>>> Do these boards actually have a macronix flash ? Most of the ones
>>>> I
>>>> know
>>>> of do not.
>>> Good question. 
>>>
>>> Actually they are pin compatible and customer can replace the
>>> existing
>>> one. FYI, there seems a NOR flash shortage worldwide which lead to
>>> requests by customer to change the BOM list.
>> I'm quite sure better half of those boards won't . If you want to
>> enable
>> the SPI NORs on the devkits, fine, but the is1, sr1500 and vining are
>> unlikely to get a replacement memory type.
> 
> Actually the way the code works is detecting JEDEC ID and associate it
> with correct flash drivers like Micron, Spansion or Macronix. Hence it
> would not yield any issue except slightly larger code.

Which on those boards I listed is useless dead code.

> But I can take
> out sr1500 and vining if it yield a concern.

IS1 too.

-- 
Best regards,
Marek Vasut