[U-Boot] [PATCH v8 4/4] common: Generic firmware loader for file system

[Tom Rini]

On Thu, Feb 22, 2018 at 03:28:12PM +0100, Marek Vasut wrote:
> On 02/22/2018 09:18 AM, Chee, Tien Fong wrote:
> > On Thu, 2018-02-15 at 15:58 +0100, Marek Vasut wrote:
> >> On 02/05/2018 08:06 AM, tien.fong.chee at intel.com wrote:
> >>>
> >>> From: Tien Fong Chee <tien.fong.chee at intel.com>
> >>>
> >>> This is file system generic loader which can be used to load
> >>> the file image from the storage into target such as memory.
> >>> The consumer driver would then use this loader to program whatever,
> >>> ie. the FPGA device.
> >>>
> >>> Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>
> >>> Reviewed-by: Lothar Waßmann <LW at KARO-electronics.de>
> >> [...]
> >>
> >>>
> >>> +#include <common.h>
> >>> +#include <errno.h>
> >>> +#include <fs.h>
> >>> +#include <fs_loader.h>
> >>> +#include <nand.h>
> >>> +#include <sata.h>
> >>> +#include <spi.h>
> >>> +#include <spi_flash.h>
> >>> +#ifdef CONFIG_SPL
> >> Are the ifdefs needed ?
> >>
> > Because spl.h contains some codes have its dependency with SPL. So, Tom
> > adviced to make this part of code depend on CONFIG_SPL.
> > However, only __weak int init_mmc() depend on the codes from spl.h, so
> > user can override their own init_mmc() if SPL is not used.
> 
> You probably dont need those ifdefs around headers.

In this case, we do.  You can only include <spl.h> on architectures
which have SPL support.

I wouldn't object to a separate patch series that adds a dummy
asm-generic/spl.h and we go that route, if it also cleans up more of the
code in general.  But I think that's separate from this series.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180222/388023c5/attachment.sig>