[U-Boot] [PATCH v1 3/4] mmc: omap_hsmmc: compile out ADMA support for am33xx and omap34xx

Jaehoon Chung jh80.chung at samsung.com
Fri Feb 23 07:06:29 UTC 2018


On 02/23/2018 12:47 AM, Tom Rini wrote:
> On Thu, Feb 22, 2018 at 11:25:47AM +0100, Jean-Jacques Hiblot wrote:
>> This reduces the size of the binary by about 600 bytes.
>>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
>> ---
>>
>>  drivers/mmc/omap_hsmmc.c | 16 ++++++++++------
>>  1 file changed, 10 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
>> index 8b57edc..31c1f66 100644
>> --- a/drivers/mmc/omap_hsmmc.c
>> +++ b/drivers/mmc/omap_hsmmc.c
>> @@ -48,6 +48,10 @@
>>  #include <dm.h>
>>  #include <power/regulator.h>
>>  
>> +#if !defined(CONFIG_AM33XX) && !defined(CONFIG_OMAP34XX)
>> +#define ADMA_SUPPORT
>> +#endif
>> +
>>  DECLARE_GLOBAL_DATA_PTR;
>>  
>>  /* simplify defines to OMAP_HSMMC_USE_GPIO */
>> @@ -93,7 +97,7 @@ struct omap_hsmmc_data {
>>  	enum bus_mode mode;
>>  #endif
>>  	u8 controller_flags;
>> -#ifndef CONFIG_OMAP34XX
>> +#ifdef ADMA_SUPPORT
> 
> How about we add CONFIG_MMC_OMAP_HS_ADMA, and select it on !AM33XX &&
> !OMAP34XX, and then test that here?  Thanks!

I agreed Tom's suggestion. 
If you can send v2 with it, I will pick these series with Tom's Reviewed's tag and Adam's Tested tag.

Best Regards,
Jaehoon Chung

> 



More information about the U-Boot mailing list