[U-Boot] [PATCH v2 3/4] mmc: omap_hsmmc: make it possible to compile out ADMA support

[Jaehoon Chung]

On 02/23/2018 09:57 PM, Tom Rini wrote:
> On Fri, Feb 23, 2018 at 01:47:36PM +0100, Jean-Jacques Hiblot wrote:
>>
>>
>> On 23/02/2018 13:21, Tom Rini wrote:
>>> On Fri, Feb 23, 2018 at 10:40:18AM +0100, Jean-Jacques Hiblot wrote:
>>>> Some platforms don't have ADMA controllers. For those platforms, compiling
>>>> it out reduces the size of the binary by about 600 bytes.
>>>> Leaving the support in doesn't break things as the driver checks at runtime
>>>> if the ADMA2 controller is present.
>>>>
>>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
>>>>
>>>> ---
>>>>
>>>> Changes in v2:
>>>> - Use a Kconfig option to compile out the ADMA support instead of relying
>>>>   on the platform architecture
>>>>
>>>>  drivers/mmc/Kconfig      |  9 +++++++++
>>>>  drivers/mmc/omap_hsmmc.c | 12 ++++++------
>>>>  2 files changed, 15 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
>>>> index f2d8256..88a1359 100644
>>>> --- a/drivers/mmc/Kconfig
>>>> +++ b/drivers/mmc/Kconfig
>>>> @@ -239,6 +239,15 @@ config MMC_OMAP_HS
>>>>  	  If unsure, say N.
>>>> +config MMC_OMAP_HS_ADMA
>>>> +	bool "ADMA support for OMAP HS MMC"
>>>> +	depends on MMC_OMAP_HS && !OMAP34XX
>>>> +	default y if !AM33XX
>>> Is this logic really the right restrictions?  Does it work on some
>>> AM33XX platforms (AM43xx?) and just never OMAP34XX?  Thanks!
>> Starting with platform am33xx there is a way to check if the ADMA controller
>> is present or not by reading a register. This register is not available in
>> OMAP34XX.
>> That being said I don't think that ADMA is available on any variant of
>> am33xx.
> 
> OK, thanks!
> 
> Reviewed-by: Tom Rini <trini at konsulko.com>

Applied to u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

>