[U-Boot] [PATCH v2 11/20] sunxi: spl: deassert the NAND controller reset line

[Maxime Ripard]

Hi Wolfgang,

On Mon, Feb 26, 2018 at 09:52:21AM +0100, Wolfgang Denk wrote:
> Dear Maxime,
> 
> In message <20180226084006.5armemyuslxgqjtw at flea.lan> you wrote:
> > 
> > > +#if defined CONFIG_MACH_SUN6I || defined CONFIG_MACH_SUN8I || \
> > > +    defined CONFIG_MACH_SUN9I || defined CONFIG_MACH_SUN50I
> > 
> > Yep, that would be better.
> 
> Actually such (ever growing) lists of board selectors are pretty much
> deprecated.
> 
> Instead, you should define a feature macro which describes the
> specific property, which you can then enable in all boards which
> have this property.

This is not really about boards but SoCs families, so the grain is
much much larger (especially since the families are now based on the
CPU these SoCs use, and we have pretty much only Cortex-A7 or A53).

> The big advantage is that (1) you don't have to touch this common
> code when you just add support for a new board and (2) the code
> becomes much easier to read and to understand.

I'm not quite sure what you mean, do you have an example of such a
construct?

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180226/49084802/attachment.sig>