[U-Boot] [PATCH v2 00/13] LS1012A PFE driver patch series

Calvin Johnson calvin.johnson at nxp.com
Tue Feb 27 16:45:41 UTC 2018


> -----Original Message-----
> From: Joe Hershberger [mailto:joe.hershberger at ni.com]
> Sent: Tuesday, February 27, 2018 9:18 PM
> To: Calvin Johnson <calvin.johnson at nxp.com>
> Cc: joe.hershberger at ni.com; u-boot at lists.denx.de; Anji Jagarlmudi
> <anji.jagarlmudi at nxp.com>; York Sun <york.sun at nxp.com>
> Subject: Re: [U-Boot] [PATCH v2 00/13] LS1012A PFE driver patch series
> 
> On Mon, Feb 26, 2018 at 10:49 PM, Calvin Johnson <calvin.johnson at nxp.com>
> wrote:
> > Hi Joe,
> >
> >> -----Original Message-----
> >> From: Joe Hershberger [mailto:joe.hershberger at ni.com]
> >> Sent: Tuesday, February 27, 2018 1:31 AM
> >> To: Calvin Johnson <calvin.johnson at nxp.com>
> >> Cc: joe.hershberger at ni.com; u-boot at lists.denx.de; Anji Jagarlmudi
> >> <anji.jagarlmudi at nxp.com>
> >> Subject: Re: [U-Boot] [PATCH v2 00/13] LS1012A PFE driver patch series
> >>
> >> Hi Calvin,
> >>
> >> On Wed, Feb 21, 2018 at 10:32 PM, Calvin Johnson <calvin.johnson at nxp.com>
> >> wrote:
> >> > Hi Joe,
> >> >
> >> >> -----Original Message-----
> >> >> From: Calvin Johnson [mailto:calvin.johnson at nxp.com]
> >> >> Sent: Thursday, February 15, 2018 7:47 PM
> >> >> To: u-boot at lists.denx.de
> >> >> Cc: joe.hershberger at ni.com; York Sun <york.sun at nxp.com>; Anji
> Jagarlmudi
> >> >> <anji.jagarlmudi at nxp.com>; Calvin Johnson <calvin.johnson at nxp.com>
> >> >> Subject: [PATCH v2 00/13] LS1012A PFE driver patch series
> >> >>
> >> >
> >> > <snip>
> >> >
> >> >> Changes in v2 series:
> >> >> 1. PFE patches submitted on top of this base patch are now merged to
> >> >> this patch.
> >> >> 2. Platform changes are segregated into different patches.
> >> >> 3. Network enabled on 2g5rdb platform
> >> >> 4. Moved from legacy to new driver model.
> >> >
> >> > Gentle reminder. Hope the PFE patches didn't miss your sight.
> >>
> >> I tried applying your series and it had many checkpatch issues. Please
> >> resolve those and resend.
> >>
> >> Thanks,
> >> -Joe
> >>
> >> -----------------
> >>
> >>
> >> Fetched U-Boot-1-9-drivers-net-pfe_eth-LS1012A-PFE-driver-introduction
> >> (823206.mbox)
> >> 823206.mbox:46: WARNING: added, moved or deleted file(s), does
> >> MAINTAINERS need updating?
> >> 823206.mbox:534: CHECK: Avoid CamelCase: <Elf32_Shdr>
> >> 823206.mbox:551: CHECK: No space is necessary after a cast
> >> 823206.mbox:669: CHECK: spaces preferred around that '&' (ctx:ExV)
> >
> > <snip>
> >
> > Looks like you have run checkpatch on the v1 series (9 patches).
> > I had submitted the v2 series (13 patches).
> >
> > However, in the v2 series, there are some checkpatch warnings like ' line over
> 80 characters'
> > which I had to ignore due to valid reasons. If there is any concern on these, I
> can work on them
> > after discussion.
> 
> Sorry about that - Only your V1 was assigned to me in patchwork, so I missed it.
> 
> Looks like V2 is assigned to York at the moment, but I'm going to
> assign it to myself since it is all about networking.

Not sure, how it got assigned to York. Thanks for taking up the patches.

Regards
Calvin


More information about the U-Boot mailing list