[U-Boot] [PATCH v2 05/13] drivers: net: pfe_eth: LS1012A PFE headers

[Joe Hershberger]

On Thu, Feb 15, 2018 at 8:17 AM, Calvin Johnson <calvin.johnson at nxp.com> wrote:
> Contains all the pfe header files.

Looks good, but I'd like to move the files.

>
> Signed-off-by: Calvin Johnson <calvin.johnson at nxp.com>
> Signed-off-by: Anjaneyulu Jagarlmudi <anji.jagarlmudi at nxp.com>
> ---
> Changes in v2:
> -Add pfe_rx_done to clear bd after packet processing
> -remove unused code under CONFIG_UTIL_PE_DISABLED
> -Used BIT and GENMASK macros wherever applicable
> -Removed generic definitions that pollutes namespace
> -File names pfe.h renamed to pfe_hw.h to be more clear as it contains
>  low level functions that directly access pfe hardware block
> -Added pfe_dm_eth.h for new driver model
> ---
>  include/dm/platform_data/pfe_dm_eth.h |  21 ++++

This is fine.

>  include/pfe_eth/pfe/cbus.h            |  77 +++++++++++++++
>  include/pfe_eth/pfe/cbus/bmu.h        |  40 ++++++++
>  include/pfe_eth/pfe/cbus/class_csr.h  | 180 ++++++++++++++++++++++++++++++++++
>  include/pfe_eth/pfe/cbus/emac.h       | 140 ++++++++++++++++++++++++++
>  include/pfe_eth/pfe/cbus/gpi.h        |  62 ++++++++++++
>  include/pfe_eth/pfe/cbus/hif.h        |  68 +++++++++++++
>  include/pfe_eth/pfe/cbus/hif_nocpy.h  |  40 ++++++++
>  include/pfe_eth/pfe/cbus/tmu_csr.h    | 148 ++++++++++++++++++++++++++++
>  include/pfe_eth/pfe/cbus/util_csr.h   |  47 +++++++++
>  include/pfe_eth/pfe/pfe_hw.h          | 163 ++++++++++++++++++++++++++++++

Please move these to include/net/pfe/*

>  include/pfe_eth/pfe_driver.h          |  59 +++++++++++
>  include/pfe_eth/pfe_eth.h             | 104 ++++++++++++++++++++
>  include/pfe_eth/pfe_firmware.h        |  17 ++++
>  include/pfe_eth/pfe_mdio.h            |  13 +++

Please move these to include/net/pfe/*

>  15 files changed, 1179 insertions(+)
>  create mode 100644 include/dm/platform_data/pfe_dm_eth.h
>  create mode 100644 include/pfe_eth/pfe/cbus.h
>  create mode 100644 include/pfe_eth/pfe/cbus/bmu.h
>  create mode 100644 include/pfe_eth/pfe/cbus/class_csr.h
>  create mode 100644 include/pfe_eth/pfe/cbus/emac.h
>  create mode 100644 include/pfe_eth/pfe/cbus/gpi.h
>  create mode 100644 include/pfe_eth/pfe/cbus/hif.h
>  create mode 100644 include/pfe_eth/pfe/cbus/hif_nocpy.h
>  create mode 100644 include/pfe_eth/pfe/cbus/tmu_csr.h
>  create mode 100644 include/pfe_eth/pfe/cbus/util_csr.h
>  create mode 100644 include/pfe_eth/pfe/pfe_hw.h
>  create mode 100644 include/pfe_eth/pfe_driver.h
>  create mode 100644 include/pfe_eth/pfe_eth.h
>  create mode 100644 include/pfe_eth/pfe_firmware.h
>  create mode 100644 include/pfe_eth/pfe_mdio.h
>

Thanks,
-Joe