[U-Boot] [PATCH v2 1/3] watchdog: Add Cadence watchdog driver

[Michal Simek]

HI,

2018-02-28 12:06 GMT+01:00 Lukasz Majewski <lukma at denx.de>:

> Hi Michal,
>
> > Hi,
> >
> > 2018-02-28 9:51 GMT+01:00 Lukasz Majewski <lukma at denx.de>:
> >
> > > Hi Michal,
> > >
> > > > From: Shreenidhi Shedi <imshedi at gmail.com>
> > > >
> > > > This IP can be found on Zynq and ZynqMP devices.
> > > > The driver was tested with reset-on-timeout; feature.
> > > >
> > > > Also adding WATCHDOG symbol to Kconfig because it is required.
> > >
> > > If I may ask - what is the purpose of adding separate WATCHDOG
> > > symbol?
> > >
> > > Cannot HW_WATCHDOG or CONFIG_WDT be reused?
> > >
> > > Please look into ULP_WATCHDOG as a reference.
> > >
> > >
> > ULP_WATCHDOG hasn't been converted to DM that's why you use
> > hw_watchdog wiring.
> >
> > CONFIG_WDT is used for enabling watchdog uclass.
> > CONFIG_WDT_CDNS - for enabling cadence DM watchdog driver
> > CONFIG_WATCHDOG - for servicing watchdog by u-boot
>         ^^^^^^^^^ - I'm just wondering about this one. How does it
>         corresponds to CONFIG_HW_WATCHDOG?
>

include/watchdog.h

 32 #if defined(CONFIG_HW_WATCHDOG) && defined(CONFIG_WATCHDOG)
 33 #  error "Configuration error: CONFIG_HW_WATCHDOG and CONFIG_WATCHDOG
can't be used together."
 34 #endif

HW_WATCHDOG - non DM drivers, WATCHDOG DM drivers.

M


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform