[U-Boot] [PATCH v2 04/29] binman: Correct operation of ObtainContents()

Simon Glass sjg at chromium.org
Mon Jul 9 19:51:59 UTC 2018


On 6 July 2018 at 10:27, Simon Glass <sjg at chromium.org> wrote:
> This method is supposed to return the contents of an entry. However at
> present there is no check that it actually does. Also some implementations
> do not return 'True' to indicate success, as required.
>
> Add a check for things working as expected, and correct the
> implementations.
>
> This requires some additional test cases to cover things which were missed
> originally. Add these at the same time.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v2: None
>
>  tools/binman/bsection.py                      |  4 ++
>  tools/binman/etype/_testing.py                |  5 ++
>  tools/binman/etype/section.py                 |  2 +-
>  tools/binman/etype/u_boot_spl_bss_pad.py      |  1 +
>  tools/binman/etype/u_boot_ucode.py            |  9 ++-
>  tools/binman/ftest.py                         | 57 +++++++++++++++----
>  tools/binman/test/57_unknown_contents.dts     | 14 +++++
>  .../test/58_x86_ucode_spl_needs_retry.dts     | 36 ++++++++++++
>  8 files changed, 114 insertions(+), 14 deletions(-)
>  create mode 100644 tools/binman/test/57_unknown_contents.dts
>  create mode 100644 tools/binman/test/58_x86_ucode_spl_needs_retry.dts

Applied to u-boot-dm


More information about the U-Boot mailing list