[U-Boot] [PATCH v2 8/8] test/py: vboot: Remove stderr redirect from openssl command

Simon Glass sjg at chromium.org
Tue Jul 10 20:57:09 UTC 2018


On 14 September 2017 at 15:34, Paul Burton <paul.burton at imgtec.com> wrote:
> The openssl command specified in test_with_algo() ultimately ends up
> being run by RunAndLog::run(), which uses it to construct a Popen object
> with the default shell=False. The stderr redirect in the command is
> therefore simply passed to openssl as an argument. With at least openssl
> 1.1.0f this causes openssl, and therefore test_vboot, to fail with:
>
>   genpkey: Use -help for summary.
>   Exit code: 1
>
> Any stderr output ought to be captured & stored in the RunAndLog
> object's output field and returned from run() via run_and_log() to
> test_with_algo() which then ignores it anyway, so we can drop the
> shell-like redirection with no ill effects. With this fix test_vboot now
> passes for me.
>
> Signed-off-by: Paul Burton <paul.burton at imgtec.com>
> Reviewed-by: Stephen Warren <swarren at nvidia.com>
>
> ---
>
> Changes in v2:
> - Place the % operator at the end of the last string line, not the start of the next.
>
>  test/py/tests/test_vboot.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Applied to u-boot-dm, thanks!


More information about the U-Boot mailing list