[U-Boot] [RFC PATCH 04/15] cmd: fpga: Cleanup error handling in connection to FPGA_NONE
Michal Simek
michal.simek at xilinx.com
Wed Jul 18 15:16:42 UTC 2018
Incorrect command is already handled and FPGA_NONE should be used only
one. In case of error CMD_RET_USAGE can be returned directly without any
addition logic around.
Signed-off-by: Michal Simek <michal.simek at xilinx.com>
---
cmd/fpga.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/cmd/fpga.c b/cmd/fpga.c
index de8505e9d4c8..af2f514dca00 100644
--- a/cmd/fpga.c
+++ b/cmd/fpga.c
@@ -171,11 +171,10 @@ int do_fpga(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
if (dev == FPGA_INVALID_DEVICE) {
puts("FPGA device not specified\n");
- op = FPGA_NONE;
+ return CMD_RET_USAGE;
}
switch (op) {
- case FPGA_NONE:
case FPGA_INFO:
break;
#if defined(CONFIG_CMD_FPGA_LOADFS)
@@ -219,13 +218,10 @@ int do_fpga(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
if (wrong_parms) {
puts("Wrong parameters for FPGA request\n");
- op = FPGA_NONE;
+ return CMD_RET_USAGE;
}
switch (op) {
- case FPGA_NONE:
- return CMD_RET_USAGE;
-
case FPGA_INFO:
rc = fpga_info(dev);
break;
--
1.9.1
More information about the U-Boot
mailing list