[U-Boot] [RFC PATCH 03/15] cmd: fpga: Move fpga_get_op to avoid local function declaration

Simon Glass sjg at chromium.org
Thu Jul 19 15:21:40 UTC 2018


Hi Michal,

On 19 July 2018 at 00:55, Michal Simek <michal.simek at xilinx.com> wrote:
> On 19.7.2018 03:32, Simon Glass wrote:
>> On 18 July 2018 at 09:16, Michal Simek <michal.simek at xilinx.com> wrote:
>>> Move fpga_get_op() to top of file to remove local function declaration
>>> and also remove useless retyping.
>>>
>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>> ---
>>>
>>>  cmd/fpga.c | 85 ++++++++++++++++++++++++++++++--------------------------------
>>>  1 file changed, 41 insertions(+), 44 deletions(-)
>>>
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> But can this not use a sub-command array?
>
> As you see the whole series is coming to that direction.
> I just needed to do some preparation steps before doing that.

Yes I t see that, thanks.

- Simon


More information about the U-Boot mailing list