[U-Boot] [RFC] Make U-Boot log great again

[Sam Protsenko]

On Wed, Jul 18, 2018 at 1:14 AM, Sam Protsenko
<semen.protsenko at linaro.org> wrote:
> On Tue, Jul 10, 2018 at 5:38 PM, Tom Rini <trini at konsulko.com> wrote:
>> On Tue, Jul 10, 2018 at 11:01:14AM +0800, Bin Meng wrote:
>>> Hello,
>>>
>>> On Fri, Mar 23, 2018 at 1:44 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
>>> > Hi,
>>> >
>>> > On Sat, Feb 17, 2018 at 3:49 AM, Robert Nelson <robertcnelson at gmail.com> wrote:
>>> >> On Fri, Feb 16, 2018 at 1:01 PM, Sam Protsenko
>>> >> <semen.protsenko at linaro.org> wrote:
>>> >>> Hi guys,
>>> >>>
>>> >>> TL;DR This is a suggestion about fixing U-Boot log, which has got
>>> >>> worse recently.
>>> >>>
>>> >>> Right now U-Boot and SPL logs are cluttered with bogus warnings like
>>> >>> these (on X15 board, but I'm pretty sure it should appear on many
>>> >>> others):
>>> >>>
>>> >>>     Loading Environment from FAT...
>>> >>>     *** Warning - bad CRC, using default environment
>>> >>>     Failed (-5)
>>> >>
>>> >
>>> > Do we plan to fix this "Failed (-5)" message? It's very confusing.
>>> > Like previous U-Boot just printing "*** Warning - bad CRC, using
>>> > default environment" is enough I think.
>>> >
>>>
>>> The v2018.07 release still has this "Failed (-5)" message on boot.
>>> When do we plan to fix this?
>>
>> I don't mean for this to sound glib, but I was expecting patches to get
>> posted to change this particular area at least.  I thought it had been
>> talked to the point where it was understood what the next steps should
>> look like?  Thanks/sorry!
>>
>
> Just to have something specific to discuss, I've sent two RFC patches:
> [1,2]. I suggest we start with messages beautifying first, as this
> seems to be main concern for most people.
>
> Tom, what do you think about [1,2]? Does it have right to exist at
> all, or should we go some other way?
>

After some discussion, new RFC patch is ready for review: [1].
Personally, I'd also like to prepend error messages with at least two
spaces or some other prefix. But that would take introducing new
pointer in gd structure. Please let me know what you think.

[1] https://lists.denx.de/pipermail/u-boot/2018-July/335223.html

> Thanks.
>
> [1] https://lists.denx.de/pipermail/u-boot/2018-July/335071.html
> [2] https://lists.denx.de/pipermail/u-boot/2018-July/335072.html
>
>> --
>> Tom