[U-Boot] [PATCH] spi: omap3: fix claim/release bus within DM

Tom Rini trini at konsulko.com
Thu Jun 28 21:52:41 UTC 2018


On Thu, Jun 28, 2018 at 10:37:10PM +0200, Hannes Schmelzer wrote:
> 
> On 06/28/2018 04:26 PM, Jagan Teki wrote:
> >On Tue, Jun 26, 2018 at 7:38 PM, Hannes Schmelzer <oe5hpm at oevsv.at> wrote:
> >>The claim/release bus function must not reset the whole SPI core because
> >>settings regarding wordlen, clock-frequency and so on made by
> >>set_wordlen, set_mode, set_speed get lost with this action. Resulting in
> >>a non-functional SPI.
> >>
> >>Without DM the failure didn't came up since after the spi_reset within
> >>claim bus all the setup (wordlen, mode, ...) was called, in DM they are
> >>called by the spi uclass.
> >>
> >>We change now the things as following for having a working SPI instance
> >>in DM:
> >>
> >>- move the spi_reset(...) to the probe call in DM for having a known
> >>hardware state after probe. Without DM we don't have a probe call, so we
> >>issue the reset as before during the claim_bus call.
> >>
> >>- in release bus we just reset the modulctrl to the reset-value (spi-
> >>slave)
> >>
> >>Signed-off-by: Hannes Schmelzer <oe5hpm at oevsv.at>
> >>
> >>---
> >Applied to u-boot-spi/master
> do we have a chance to get into rc3 with this?

I would like to see this and the other fixes in for that, yes, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180628/cb6e7553/attachment.sig>


More information about the U-Boot mailing list