[U-Boot] [PATCH 3/3] test/py: add spi_flash tests

Michal Simek monstr at monstr.eu
Mon Mar 5 07:58:24 UTC 2018


On 1.3.2018 22:18, Stephen Warren wrote:
> On 03/01/2018 04:48 AM, Liam Beguin wrote:
>> On 1 March 2018 at 01:59, Michal Simek <michal.simek at xilinx.com> wrote:
> ...
>>> Also these randomized data/lengths were able to find out more issues
>>> than fixed one. I was playing with that randomized test order and I see
>>> that not all current tests are self contained and this will be good to
>>> run too.
>>
>> I'll add options to randomize in v2.
> 
> I'd strongly prefer the tests to be deterministic and not do random
> different actions each time they're run. That way, any failures are much
> easier to track down. Writing randomly generated data is fine, but not
> random access patterns or sets of operations.
> 
> Although I suppose you could implement two sets of tests; one that does
> a static set of operations driven by a table in the board config file,
> and one that does a more randomized set of operations controlled by
> limits set by a table in the board config file.

The thing is that I have real experience with random tests which were
able to find out issues in the driver compare to fixed tests.

But I have not a problem with two set of tests.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180305/43056d00/attachment.sig>


More information about the U-Boot mailing list