[U-Boot] [PATCH] spi: atcspi200: Full dm conversion

[陳建志]

2018-03-07 19:02 GMT+08:00 Jagan Teki <jagannadh.teki at gmail.com>:
>
>
> On 07-Mar-2018 1:12 PM, "陳建志" <rickchen36 at gmail.com> wrote:
>
> 2018-03-07 15:20 GMT+08:00 Jagan Teki <jagannadh.teki at gmail.com>:
>> On Wed, Mar 7, 2018 at 12:34 PM, Andes <uboot at andestech.com> wrote:
>>> From: Rick Chen <rick at andestech.com>
>>>
>>> atcspi200_spi now support dt along with platform data.
>>>
>>> Signed-off-by: Rick Chen <rick at andestech.com>
>>> Signed-off-by: Rick Chen <rickchen36 at gmail.com>
>>> Signed-off-by: Greentime Hu <green.hu at gmail.com>
>>> ---
>>>  drivers/spi/atcspi200_spi.c              |  134
>>> ++++++------------------------
>>>  include/dm/platform_data/spi_atcspi200.h |   15 ++++
>>
>> I have seen only two boards using this driver (adp-ae3xx_defconfig,
>> nx25-ae250_defconfig) and both are enabled DM_SPI with OF_CONTROL why
>> we need to have platdata for this? here [1] is non-dm code drop.
>>
>> [1] https://patchwork.ozlabs.org/patch/882404/
>
> Hi Tagan Teki
>
> I just refer to [PATCH][Boards Need to Switch DM] spi: davinci: Full
> dm conversion
> And have this modification.
>
> So it is not necessary to add platdata for atcspi200_spi, just drop
> non-dm code, right ?
>
>
> There are two boards using this driver adp-ae3xx_defconfig and
> nx25-ae250_defconfig, both of them use DM_SPL with dr. With this reason it
> is not require to add pdata here?

Thanks for your explanations.

Rick