[U-Boot] [PATCH] imximage: Check the IVT offset in the correct location

[Breno Matheus Lima]

Hi Fabio,

2018-03-08 17:40 GMT-03:00 Fabio Estevam <festevam at gmail.com>:
> From: Fabio Estevam <fabio.estevam at nxp.com>
>
> Sometimes imximage throws the following error:
>
>   CFGS    board/freescale/vf610twr/imximage.cfg.cfgtmp
>   CFGS    board/freescale/vf610twr/imximage.cfg.cfgtmp
>   MKIMAGE u-boot-dtb.imx
> Error: No BOOT_FROM tag in board/freescale/vf610twr/imximage.cfg.cfgtmp
> arch/arm/mach-imx/Makefile:100: recipe for target 'u-boot-dtb.imx' failed
>
> This problem happens because imximage_ivt_offset is being checked
> at un unsafe point, and in some cases it can be checked prior to
> its assignment.
>
> Fix this issue by only checking imximage_ivt_offset after its
> assignment has really occurred.
>
> Introduce a check_ivt_offset() function to help on this task.
>
> Reported-by: Breno Lima <breno.lima at nxp.com>
> Reported-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>

Tested-by: Breno Lima <breno.lima at nxp.com>

Thanks,
Breno Lima