[U-Boot] [PULL] Please pull u-boot-imx
Stefano Babic
sbabic at denx.de
Fri Mar 9 11:11:14 UTC 2018
Hi Fabio,
On 09/03/2018 11:42, Fabio Estevam wrote:
> Hi Stefano,
>
> On Fri, Mar 9, 2018 at 7:13 AM, Stefano Babic <sbabic at denx.de> wrote:
>> Hi Tom,
>>
>> Fabio fixed a build issue yesterday. It is just a single patch, but it
>> should be flow into the release. You can pick it udirectly p, but I have
>> also applied to u-boot-imx to make things easier.
>
> Troy made a good observation yesterday: he asked me if after applying
> this patch the error is still shown when BOOT_FROM is not passed in
> the cfg file.
>
> I tested it and it does not.
Something strange happens...
>
> So we have some options here that I would like to discuss:
>
> 1. Drop the error message completely. This message is only helpful for
> developers during bring up phase
>
> 2. Understand better the problem and fix the parallel build issue
>
> I think 1 can be done for the upcoming release as the negative effect
> of breaking builds is worse than showing the lack of BOOT_FROM tag.
My concern is more that build is broken, yes. Release is now upcoming,
we can do just a few changes.
>
> Option number 2 would require more time to implement.
>
> If you like I can resent a v2 of option 1 where the error message is removed.
It is a hack, but we can do just for the release. I have already applied
V1, I will drop it from u-boot-imx. I will also apply "imx: syscounter:
make sure asm is volatile" as you told me today, and then I send a PR
with these two patches to Tom.
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
More information about the U-Boot
mailing list