[U-Boot] [PATCH 1/6] usb: ehci-generic: handle phy power on/off

patrice.chotard at st.com patrice.chotard at st.com
Wed Mar 14 16:48:53 UTC 2018


From: Patrice Chotard <patrice.chotard at st.com>

Add generic_phy_power_on() and generic_phy_power_off()
calls to switch ON/OFF phy during probe and remove functions.

Signed-off-by: Christophe Kerello <christophe.kerello at st.com>
Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
---
 drivers/usb/host/ehci-generic.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/usb/host/ehci-generic.c b/drivers/usb/host/ehci-generic.c
index 1cb92c033870..2edd6d7433e3 100644
--- a/drivers/usb/host/ehci-generic.c
+++ b/drivers/usb/host/ehci-generic.c
@@ -106,6 +106,12 @@ static int ehci_usb_probe(struct udevice *dev)
 			pr_err("failed to init usb phy\n");
 			goto reset_err;
 		}
+
+		err = generic_phy_power_on(&priv->phy);
+		if (err) {
+			dev_err(dev, "failed to power on usb phy\n");
+			goto phy_power_err;
+		}
 	}
 
 	hccr = map_physmem(dev_read_addr(dev), 0x100, MAP_NOCACHE);
@@ -120,6 +126,13 @@ static int ehci_usb_probe(struct udevice *dev)
 
 phy_err:
 	if (generic_phy_valid(&priv->phy)) {
+		ret = generic_phy_power_off(&priv->phy);
+		if (ret)
+			dev_err(dev, "failed to power off usb phy\n");
+	}
+
+phy_power_err:
+	if (generic_phy_valid(&priv->phy)) {
 		ret = generic_phy_exit(&priv->phy);
 		if (ret)
 			pr_err("failed to release phy\n");
@@ -147,6 +160,10 @@ static int ehci_usb_remove(struct udevice *dev)
 		return ret;
 
 	if (generic_phy_valid(&priv->phy)) {
+		ret = generic_phy_power_off(&priv->phy);
+		if (ret)
+			return ret;
+
 		ret = generic_phy_exit(&priv->phy);
 		if (ret)
 			return ret;
-- 
1.9.1



More information about the U-Boot mailing list