[U-Boot] [PATCH v3 02/11] sunxi: Add I2C_SUN6I_P2WI kconfig entry

Maxime Ripard maxime.ripard at bootlin.com
Fri Mar 16 06:49:08 UTC 2018


Hi,

On Wed, Mar 14, 2018 at 07:14:08PM +0530, Jagan Teki wrote:
> On Wed, Mar 14, 2018 at 6:52 PM, Maxime Ripard
> <maxime.ripard at bootlin.com> wrote:
> > On Wed, Mar 14, 2018 at 06:29:45PM +0530, Jagan Teki wrote:
> >> Add simple and meaningful kconfig option for p2wi.c
> >> instead of using MACH type on Makefile.
> >>
> >> p2wi is an I2C controller, so used the same on kconfig
> >> definition.
> >
> > It's not an I2C controller, the bus is different, as you have shown in
> > the Kconfig option.
> 
> Since it's two-wire bus which considered as I2C Linux I've reused
> similar naming convention.

Right, but we're not in Linux, this is not an I2C driver in U-Boot
(and if it was to be done again, it shouldn't be an I2C driver in
Linux either, but that's a different story), and it's not an I2C bus
either. So I guess we can also drop the I2C part from the Kconfig help
and symbol.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180316/e2bad711/attachment.sig>


More information about the U-Boot mailing list