[U-Boot] [PATCH] davinci: omapl138_lcdk: fix PLL0 frequency

[Sekhar Nori]

On Thursday 15 March 2018 08:32 PM, David Lechner wrote:
> On 03/15/2018 09:56 AM, Tom Rini wrote:
>> On Thu, Mar 15, 2018 at 08:01:58PM +0530, Sekhar Nori wrote:
>>> On Thursday 15 March 2018 07:12 PM, Sekhar Nori wrote:
>>>> On Thursday 15 March 2018 06:04 PM, Sekhar Nori wrote:
>>>>> Thanks for the patch and great description. It looks correct to me.
>>>>> Hopefully I can provide some testing feedback too soon.
>>>>
>>>> Something seems to have broken MMC/SD support on OMAP-L138 LCDK on
>>>> 2018.03[1]. 2018.01 works fine[2].
>>>>
>>>> Will check what went wrong.
>>>
>>> The commit that broke is 6aa4ad8e3820adefaf09fe21efae06772003620f
>>> "Convert CONFIG_SOC_DA8XX et al to Kconfig". The commit prior to that
>>> works. I cannot revert it cleanly on latest mainline.
>>>
>>> I have copied others involved in that commit for help.
>>
>> I would check into what SOC_DA8XX selects/implies, perhaps something
>> isn't quite right for DA8XX vs DA850 vs DA830 ?  Thanks!
>>
> 
> Indeed:
> 
> +config SOC_DA850
> +    bool
> +    select SOC_DA8XX
> +    select SYS_DA850_DDR_INIT if SUPPORT_SPL || DA850_LOWLEVEL
> +
> +config SOC_DA8XX
> +    bool
> +    select SYS_DA850_PLL_INIT if SUPPORT_SPL || DA850_LOWLEVEL
> +
> +config MACH_DAVINCI_DA850_EVM
> +    bool
> +
> 
> I believe that
> 
>     select SYS_DA850_DDR_INIT if SUPPORT_SPL || DA850_LOWLEVEL
> 
> should be under SOC_DA8XX instead of SOC_DA850.
> 
> The LCDK board only selects SOC_DA8XX and not SOC_DA850, whereas
> other DA850 family boards all select SOC_DA850. This would explain
> why the LCDK is broken, but not other boards.

In the latest mainline, after commit 2e87980580d0 ("davinci: Fix
omapl138_lcdk builds"), SYS_DA850_DDR_INIT remains unselected for all
boards. So, I believe boot should be broken on all DA850 boards.

There is no DA830 support in U-Boot anymore. So, SOC_DA8XX is
effectively is same as SOC_DA850.

Thanks,
Sekhar